[asterisk-dev] [Code Review] 4052: chan_sip: Failure to receive ACK to SIP re-INVITE results in dialog leak.

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4052/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 9:38 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed missing space.
Updated tests section.


Bugs: ASTERISK-20784
    https://issues.asterisk.org/jira/browse/ASTERISK-20784


Repository: Asterisk


Description
-------

A INVITE> asterisk INVITE> B
A <200 OK asterisk <200 OK B
A -ACK->  asterisk --ACK--> B
          asterisk <INVITE B
          asterisk 200 OK> B
                  (ack lost)
A -BYE--> asterisk
A <200 OK asterisk

At this point, the B leg leaks.

This patch is a re-indented version of patch_asterisk_20784.txt by
NITESH BANSAL.


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 424667 

Diff: https://reviewboard.asterisk.org/r/4052/diff/


Testing (updated)
-------

See: https://reviewboard.asterisk.org/r/4051/
Tested against Asterisk 1.8.

Ran 69 tests from tests/channels/SIP (5 failures, unchanged by the patch).


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141009/9b387924/attachment.html>