[asterisk-dev] [Code Review] 4039: res_rtp_asterisk: Crash if no candidates received for component

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4039/#review13462
-----------------------------------------------------------


I don't think this goes far enough. What if I receive no candidates for RTCP? It would still crash.

- Joshua Colp


On Oct. 1, 2014, 3:43 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4039/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 3:43 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-24383
>     https://issues.asterisk.org/jira/browse/ASTERISK-24383
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When starting ice if there is not at least one remote ice candidate with an RTP component asterisk will crash. This is due to an assertion in pjnath as it expects at least one candidate with an RTP component. Added a check to make sure at least one candidate contains an RTP component.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_rtp_asterisk.c 424285 
> 
> Diff: https://reviewboard.asterisk.org/r/4039/diff/
> 
> 
> Testing
> -------
> 
> Sent asterisk a list of ice candidates containing only RTCP components (no RTP ones) and observed the crash.  After applying the patch ran the scenario again and it did not crash.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141007/e9014e88/attachment.html>