[asterisk-dev] [Code Review] 4049: res_fax: Fix reference leak caused by gateway sessions being added to faxregistry.container twice

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4049/#review13461
-----------------------------------------------------------



/branches/1.8/res/res_fax.c
<https://reviewboard.asterisk.org/r/4049/#comment23986>

    I can't seem to find where the reserved session is actually linked into the faxregistry container. Have you verified that everything is properly balanced in the ref logs with this patch?


- opticron


On Oct. 5, 2014, 10:10 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4049/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 10:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24392
>     https://issues.asterisk.org/jira/browse/ASTERISK-24392
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Reserved fax gateway sessions are added to faxregistry.container, then added again when the session is 'really' created.  It seems that when it is re-added it adds a second reference into the container due to the id being different.  Removal of the original list entry is not successful.  This prevents the session from ever being unallocated.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_fax.c 424175 
> 
> Diff: https://reviewboard.asterisk.org/r/4049/diff/
> 
> 
> Testing
> -------
> 
> Verified this resolves the leak in 11 and 12.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141007/234d9b7b/attachment.html>