[asterisk-dev] [Code Review] 4048: res_fax: Fix fax handler module reference leak

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4048/
-----------------------------------------------------------

(Updated Oct. 6, 2014, 12:49 p.m.)


Review request for Asterisk Developers.


Changes
-------

Switch to older JIRA ticket.


Bugs: ASTERISK-18923
    https://issues.asterisk.org/jira/browse/ASTERISK-18923


Repository: Asterisk


Description
-------

fax_session_reserve adds a reference to the fax driver's module, then fax_session_new adds another reference, but when the session is freed it only removes a single reference to the module.

This fixes it by unreferencing the module from fax_session_new when it is based on a reserved session.


Diffs
-----

  /branches/1.8/res/res_fax.c 424175 

Diff: https://reviewboard.asterisk.org/r/4048/diff/


Testing
-------

In testsuite against 11 verified that res_fax_spandsp now unloads in tests that previously leaked references to the module.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141006/152bc260/attachment.html>