[asterisk-dev] [Code Review] 4047: astobj2: ao2_callback with OBJ_MULTIPLE causes REF_DEBUG to report false leaks

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4047/#review13456
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On Oct. 5, 2014, 7:44 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4047/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 7:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24390
>     https://issues.asterisk.org/jira/browse/ASTERISK-24390
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When ao2_callback is run with OBJ_MULTIPLE and not OBJ_NODATA it allocates a temporary container.  When this temporary container is destroyed it does not record unref's for it's items to the refs log.  This causes refcounter.py to incorrectly flag objects that were iterated as leaked.
> 
> The diff for 11 is slightly different, it replaces __ao2_container_alloc with ao2_container_alloc_options.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/astobj2.c 424175 
> 
> Diff: https://reviewboard.asterisk.org/r/4047/diff/
> 
> 
> Testing
> -------
> 
> Against 11
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141006/d5afc6c7/attachment-0001.html>