[asterisk-dev] [Code Review] 4037: Release AMI connections on shutdown

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4037/#review13452
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On Oct. 3, 2014, 3:39 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4037/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 3:39 p.m.)
> 
> 
> Review request for Asterisk Developers and opticron.
> 
> 
> Bugs: ASTERISK-24378
>     https://issues.asterisk.org/jira/browse/ASTERISK-24378
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Release AMI connections on shutdown.
> 
> 
> I've looked further into this, I believe it has no effect on events generated after manager_shutdown.  manager_shutdown free's mgr_sessions, preventing __ast_manager_event_multichan from reaching any active sessions.  Note this wouldn't be the case with Asterisk 1.8 as the sessions container is never freed, yet another reason I'm proposing this fix for 11+.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/manager.c 424175 
> 
> Diff: https://reviewboard.asterisk.org/r/4037/diff/
> 
> 
> Testing
> -------
> 
> Tested with tests/channels/SIP/route.  Verified the AMI session is leaked without this patch, released with this patch.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141003/51fa117d/attachment.html>