[asterisk-dev] [Code Review] 4045: chan_sip: process_sdp leaks on an error path

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4045/#review13444
-----------------------------------------------------------

Ship it!


Pretty obvious little oversight, looks good to go.

- Jonathan Rose


On Oct. 1, 2014, 9:43 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4045/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 9:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24385
>     https://issues.asterisk.org/jira/browse/ASTERISK-24385
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> process_sdp leaks on an error path where crypto lines are expected but not provided.
> 
> It appears this was fixed during the media format updates.  Version 13+ does goto process_sdp_cleanup, I have not tested in 13+, but in 11/12 it is an error to run offered_media_list_destroy during this error handler.  This bug was found via tests/channels/SIP/SDP_offer_answer and tests/channels/SIP/noload_res_srtp_attempt_srtp.  In both cases the tests currently cause a leak in 11/12.  If the code is updated to goto process_sdp_cleanup it causes these tests to fail, that is why I created the label process_sdp_cleanup_b to skip offered_media_list_destroy.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 424335 
> 
> Diff: https://reviewboard.asterisk.org/r/4045/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141002/93b777c3/attachment.html>