[asterisk-dev] [Code Review] 4046: audiohooks: Reevaluate the bridge technology when an audiohook is added or removed.

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4046/#review13443
-----------------------------------------------------------

Ship it!


Code looks good and I confirmed that the patch fixes the behavior I noted on the issue. Ship it, ship it good.

- Jonathan Rose


On Oct. 2, 2014, 4:35 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4046/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2014, 4:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24195
>     https://issues.asterisk.org/jira/browse/ASTERISK-24195
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adding a mixmonitor to a channel causes the bridge to change technologies from native to simple_bridge so the call can be recorded.  However, when the mixmonitor is stopped the bridge does not switch back to the native technology.
> 
> * Added unbridge requests to reevaluate the bridge when a channel audiohook is removed.
> 
> * Moved the unbridge request into ast_audiohook_attach() ensure that the bridge reevaluates whenever an audiohook is attached.  This simplified the mixmonitor and chan_spy start code as well.
> 
> * Added defensive code to stop_mixmonitor_full() in case additional arguments are ever added to the StopMixMonitor application.
> 
> * Made ast_framehook_detach() not do an unbridge request if the framehook does not exist.
> 
> * Made ast_framehook_list_fixup() do an unbridge request if there are any framehooks.  Also simplified the loop.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/framehook.c 424382 
>   /branches/12/main/audiohook.c 424382 
>   /branches/12/apps/app_mixmonitor.c 424382 
>   /branches/12/apps/app_chanspy.c 424382 
> 
> Diff: https://reviewboard.asterisk.org/r/4046/diff/
> 
> 
> Testing
> -------
> 
> 1 Made SIP A call SIP B such that directmedia was possible.
> 2 Added a MixMonitor recorder to SIP A using AMI MixMonitor action.
> 3 The bridge technology changed to simple_bridge
> 4 Stopped the MixMonitor recorder using AMI StopMixMonitor action.
> 5 The bridge technology now changes to native with the patch.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141002/0f6a06ef/attachment-0001.html>