[asterisk-dev] [Code Review] 4040: Manager: Add missing fields and documentation for CoreShowChannels

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4040/#review13439
-----------------------------------------------------------

Ship it!


Minor nits.


branches/12/main/manager.c
<https://reviewboard.asterisk.org/r/4040/#comment23971>

    Isn't there a standard ActionID reference that should be used here?  Like what is used a few lines above?



branches/12/main/manager.c
<https://reviewboard.asterisk.org/r/4040/#comment23970>

    Please declare one variable at a time:
    int a;
    int b;
    ...


- rmudgett


On Oct. 1, 2014, 2:54 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4040/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 2:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24262
>     https://issues.asterisk.org/jira/browse/ASTERISK-24262
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This corrects some issues introduced in the responses to the CoreShowChannels AMI command as well as adding documentation for the responses. The command in Asterisk 12 was missing the following fields: Duration, Application, ApplicationData, and BridgedChannel and BridgedUniqueID (replaced with BridgeId).
> 
> 
> Diffs
> -----
> 
>   branches/12/main/manager.c 424263 
> 
> Diff: https://reviewboard.asterisk.org/r/4040/diff/
> 
> 
> Testing
> -------
> 
> Verified that the missing functionality was restored.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141002/7e325d82/attachment.html>