[asterisk-dev] [Code Review] 4042: repotools: Give up with an error if configure or Makefile.in is newer than Makefile

Corey Farrell reviewboard at asterisk.org
Wed Oct 1 16:14:13 CDT 2014



> On Oct. 1, 2014, 5:04 p.m., rmudgett wrote:
> > /Makefile.in, line 55
> > <https://reviewboard.asterisk.org/r/4042/diff/1/?file=67816#file67816line55>
> >
> >     It shouldn't be necessary to run configure to uninstall.

Guess I hadn't really thought this one out.  If you update the repository and didn't re-configure, you are uninstalling the stuff installed by the current Makefile (without the Makefile.in updates).  Fixed.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4042/#review13432
-----------------------------------------------------------


On Oct. 1, 2014, 4:59 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4042/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 4:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Repotools
> 
> 
> Description
> -------
> 
> After running 'svn up' on repotools, if Makefile.in or configure is updated no error is provided if you run 'make' without re-running ./configure.  This change provides that error message.
> 
> 
> Diffs
> -----
> 
>   /Makefile.in 884 
> 
> Diff: https://reviewboard.asterisk.org/r/4042/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> Note this fix unfortunately will not protect anyone until after they re-run configure once to update Makefile from this change.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141001/abf6a700/attachment.html>


More information about the asterisk-dev mailing list