[asterisk-dev] [Code Review] 4213: Stasis: Fix StasisStart and StasisEnd ordering and missing events

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4213/
-----------------------------------------------------------

Review request for Asterisk Developers and Mark Michelson.


Bugs: ASTERISK-24537
    https://issues.asterisk.org/jira/browse/ASTERISK-24537


Repository: Asterisk


Description
-------

This corrects several bugs that currently exist in the 12/13/trunk stasis application code.

* Masquerades now swap channel topics appropriately
* StasisStart and StasisEnd publishing is now properly restricted to controlling apps via app topics
* StasisEnd published because of replacement via masquerade-in is now published as a byproduct of the associated StasisStart to avoid race conditions
* StasisEnds now appear in some cases in which they were missing involving masquerades and bridge swaps into and out of Stasis()


Diffs
-----

  branches/12/res/stasis/app.c 428504 
  branches/12/res/stasis/app.h 428504 
  branches/12/res/res_stasis.c 428504 
  branches/12/main/channel_internal_api.c 428504 
  branches/12/main/channel.c 428504 
  branches/12/include/asterisk/channel.h 428504 

Diff: https://reviewboard.asterisk.org/r/4213/diff/


Testing
-------

Ran existing ARI tests and a few new ones that are in-progress along with the scenarios that originally found these issues.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141125/ffb0f6e3/attachment.html>