[asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167

[Matt Jordan]

> On Nov. 19, 2014, 12:47 p.m., rmudgett wrote:
> > /branches/13/main/bridge_basic.c, lines 3032-3036
> > <https://reviewboard.asterisk.org/r/4196/diff/2/?file=69139#file69139line3032>
> >
> >     Would we want these sounds to be interruptible with a digit for the next attempt?
> >     
> >     Note an ast_stopstream(chan) is needed to actually stop a stream interrupted by a digit if so.

I don't think so - or if so, that's an improvement for a later date.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4196/#review13824
-----------------------------------------------------------


On Nov. 19, 2014, 11:35 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4196/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2014, 11:35 a.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In https://reviewboard.asterisk.org/r/4167, two bugs were introduced:
> 
> * Prior to entering the features retry loop, the buffer that holds the collected digits is wiped. However, this inadvertently wipes out the first collected digit on the first pass through, which is obtained in ast_stream_and_wait. This caused all of the features tests to fail.
> * If ast_app_dtget returns a hangup (-1), the loop would retry incorrectly. If we detect a hangup, we have to stop trying the feature.
> 
> This patch fixes both issues.
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/bridge_basic.c 428255 
> 
> Diff: https://reviewboard.asterisk.org/r/4196/diff/
> 
> 
> Testing
> -------
> 
> Tested with the atxfer_nominal test. Prior to this patch it would fail; with this patch it completes successfully.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141119/1a153eda/attachment.html>