[asterisk-dev] [Code Review] 4187: res_pjsip_refer: Ensure Refer-To is NULL terminated and parse it as a URI

Joshua Colp reviewboard at asterisk.org
Wed Nov 19 05:50:22 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4187/
-----------------------------------------------------------

(Updated Nov. 19, 2014, 5:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 428195


Bugs: ASTERISK-24508
    https://issues.asterisk.org/jira/browse/ASTERISK-24508


Repository: Asterisk


Description
-------

Currently when parsing the Refer-To header there is no guarantee that it will be NULL terminated. It is also parsed as a 'To' header when in reality it should be parsed as a URI as parsing as a 'To' header may sometimes (seemingly) fail. This change fixes both.


Diffs
-----

  /branches/12/res/res_pjsip_refer.c 427708 

Diff: https://reviewboard.asterisk.org/r/4187/diff/


Testing
-------

Did transfers, confirmed they still work.

Provided patch to reporter and they confirmed it fixed the issue.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141119/1d840d82/attachment.html>


More information about the asterisk-dev mailing list