[asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4090/#review13810
-----------------------------------------------------------


Got a small problem with this...   When runtests.py checks to see if asterisk running it does 'pidof asterisk' which doesn't catch anything if asterisk was started with valgrind.  If you ctrl-c out of a -V test, valgrind is left running and a subsequent runtests.py can't kill it because it doesn't find it.


- George Joseph


On Nov. 18, 2014, 8:49 a.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4090/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 8:49 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds very basic valgrind support, which is convenient for manual test runs but does not (yet) include support for more automated valgrind usage. 
> 
> 1) CLI flag '-V' enables valgrind (./runtests -V -t tests/test)
> 
> 2) Minimal changes to testsuite, other improvements can be added later if desired
> 
> 3) Valgrind output is picked up by error logging and shown after test run.
> 
> 4) Unlike previous valgrind attempt, this one works fine on tests with multiple asterisk instances
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/runtests.py 5733 
>   /asterisk/trunk/lib/python/asterisk/test_case.py 5733 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 5733 
> 
> Diff: https://reviewboard.asterisk.org/r/4090/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141118/5607dea3/attachment.html>