[asterisk-dev] [Code Review] 4194: ast_str: Fix improper member access to struct ast_str members.

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4194/#review13809
-----------------------------------------------------------

Ship it!


Ship It!

- Corey Farrell


On Nov. 18, 2014, 3:03 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4194/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 3:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Accessing members of struct ast_str outside of the string manipulation API routines is invalid since struct ast_str is supposed to be opaque.
> 
> 
> Diffs
> -----
> 
>   /branches/11/res/res_calendar.c 428170 
>   /branches/11/channels/sip/security_events.c 428170 
>   /branches/11/channels/chan_sip.c 428170 
> 
> Diff: https://reviewboard.asterisk.org/r/4194/diff/
> 
> 
> Testing
> -------
> 
> Use of the DEBUG_OPAQUE define no longer produces compile errors with the patch.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141118/c4216746/attachment.html>