[asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4186/
-----------------------------------------------------------

(Updated Nov. 18, 2014, 1:36 p.m.)


Review request for Asterisk Developers and rmudgett.


Changes
-------

Fix description


Bugs: ASTERISK-24535
    https://issues.asterisk.org/jira/browse/ASTERISK-24535


Repository: Asterisk


Description (updated)
-------

ast_string_fields_copy relies on the fact that __ast_string_field_release_active never previously zeroed pool->used, so keeping the existing pointer was "ok".  Setting each field to __ast_string_field_empty after releasing the memory seems to resolve the issue.


Diffs
-----

  /branches/12/include/asterisk/stringfields.h 428167 

Diff: https://reviewboard.asterisk.org/r/4186/diff/


Testing
-------

Full testsuite against 12.  I had 17 failures, but that is normal on my system.  I re-ran the 17 tests without this patch, they still failed.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141118/26b67343/attachment.html>