[asterisk-dev] [Code Review] 4172: Testsuite: tests for res_pjsip_config_wizard

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4172/#review13782
-----------------------------------------------------------



asterisk/trunk/tests/channels/pjsip/config_wizard/AMISendTest.py
<https://reviewboard.asterisk.org/r/4172/#comment24274>

    You can at least append your name here :-)



asterisk/trunk/tests/channels/pjsip/config_wizard/AMISendTest.py
<https://reviewboard.asterisk.org/r/4172/#comment24275>

    There's a good chance this will throw an exception if there is no ACTION in the config. How about:
    
    action = self.config.get('ACTION')
    if not action:
        return
    
    ...


- Matt Jordan


On Nov. 11, 2014, 4:45 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4172/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 4:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> These are the tests for res_pjsip_config_wizard https://reviewboard.asterisk.org/r/4165/
> 
> When I cloned AMISendTest, I made a small change that might be usefull for other AMI tests...  You now specify the ACTION in test-config.yaml rather than having ACTION hard coded in AMISendTest.py and the results in test-config.yaml.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/pjsip/tests.yaml 5920 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/trunk/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/trunk/configs/ast1/pjsip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/registration/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/registration/configs/ast1/pjsip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/phone/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/phone/configs/ast1/pjsip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/config_wizard/AMISendTest.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141115/f48871c3/attachment.html>