[asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4182/
-----------------------------------------------------------

(Updated Nov. 14, 2014, 9:12 a.m.)


Review request for Asterisk Developers.


Changes
-------

I also realized I should have gone further with the fix before posting it.  I started fixing it another way but prefer Corey's suggestion to my idea.


Repository: Asterisk


Description
-------

When connecting to the remote console, an identifier string is first provided that consists of hostname/pid/version.  This is parsed by the remote instance in a buffer allocated to only 80 bytes.  It is possible for a combination of very long hostname and very long asterisk version number to be greater than 80 characters, causing the parsing to fall off the end of the allocated memory buffer and potentially crash.

This change increases the buffer from 80 to 256 to significantly reduce that possibility.


Diffs (updated)
-----

  /branches/13/main/asterisk.c 427813 

Diff: https://reviewboard.asterisk.org/r/4182/diff/


Testing
-------

It stopped crashing on a repeated test I was running where the atoi of the version # happen to hit the end of the buffer.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141114/d16abea4/attachment.html>