[asterisk-dev] [Code Review] 4175: Fix race condition where identical SIP requests are processed by multiple threads (Asterisk 13)

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4175/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

See /r/4174 for details about the issue that is being fixed.

The main difference here is that since res_pjsip_pubsub.c was refactored between Asterisk 12 and Asterisk 13, the fix here is much simpler. Instead of having to save the result of dialog creation on the rdata's mod_data array, we can instead just add an extra output parameter when creating the subscription tree to determine if dialog creation was successful.


Diffs
-----

  /branches/13/res/res_pjsip_session.c 427675 
  /branches/13/res/res_pjsip_pubsub.c 427675 
  /branches/13/res/res_pjsip.c 427675 
  /branches/13/main/features.c 427675 
  /branches/13/include/asterisk/res_pjsip.h 427675 

Diff: https://reviewboard.asterisk.org/r/4175/diff/


Testing
-------

I reran the subscription presence tests to be sure that they are not affected by this change.


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141112/d7a27f2a/attachment.html>