[asterisk-dev] [Code Review] 4152: chan_console: Fix reference leaks to pvt

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4152/#review13700
-----------------------------------------------------------

Ship it!


Minor nits.


/branches/11/channels/chan_console.c
<https://reviewboard.asterisk.org/r/4152/#comment24193>

    Please add the missing braces here. It looks awkward now.



/branches/11/channels/chan_console.c
<https://reviewboard.asterisk.org/r/4152/#comment24194>

    Idem.



/branches/11/channels/chan_console.c
<https://reviewboard.asterisk.org/r/4152/#comment24195>

    Idem.



/branches/11/channels/chan_console.c
<https://reviewboard.asterisk.org/r/4152/#comment24196>

    Idem.


- wdoekes


On Nov. 6, 2014, 10:52 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4152/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 10:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24504
>     https://issues.asterisk.org/jira/browse/ASTERISK-24504
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Fix a bunch of calls to get_active_pvt where the reference is never released.
> 
> Leaks found by Bamboo https://bamboo.asterisk.org/bamboo/artifact/AST-ATSRC1/C632TE/build-2/Test-Suite-Logs/apps/queues/queue_baseline/run_1/ast1/var/log/asterisk/refs.txt
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_console.c 427380 
> 
> Diff: https://reviewboard.asterisk.org/r/4152/diff/
> 
> 
> Testing
> -------
> 
> No.  Visually inspected changes, they are straight forward.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141106/676e4555/attachment-0001.html>