[asterisk-dev] [Code Review] 4143: testsuite: Close HTTP connections when test is complete to prevent reported leaks in tests/phoneprov/res_phoneprov and tests/manager/config

Corey Farrell reviewboard at asterisk.org
Tue Nov 4 14:57:57 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4143/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 2:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 5887


Repository: testsuite


Description
-------

HTTP connections left open when a test completes causes leaks to be reported by REF_DEBUG.  This ensures the connections are closed in two tests to ensure they pass with REF_DEBUG.  Remove import of syncami from tests/channels/SIP/pcap_demo since it's not actually used.


Diffs
-----

  /asterisk/trunk/tests/phoneprov/res_phoneprov/run-test 5878 
  /asterisk/trunk/tests/manager/config/ManagerConfigTest.py 5878 
  /asterisk/trunk/tests/channels/SIP/pcap_demo/run-test 5878 
  /asterisk/trunk/lib/python/asterisk/syncami.py 5878 

Diff: https://reviewboard.asterisk.org/r/4143/diff/


Testing
-------

Against 13, tests passed with no leaks reported.  Verified no other active test uses syncami.  Only tests/channels/SIP/nat_supertest used it but that test is disabled per ASTERISK-19565.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141104/f1e5a88c/attachment.html>


More information about the asterisk-dev mailing list