[asterisk-dev] [Code Review] 4147: config: BUG: Restore ability for non-templates to be used as base objects in config.

Scott Griepentrog reviewboard at asterisk.org
Tue Nov 4 11:28:44 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4147/#review13667
-----------------------------------------------------------

Ship it!


Ship It!

- Scott Griepentrog


On Nov. 4, 2014, 11:06 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4147/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:06 a.m.)
> 
> 
> Review request for Asterisk Developers and Scott Griepentrog.
> 
> 
> Bugs: ASTERISK-24487
>     https://issues.asterisk.org/jira/browse/ASTERISK-24487
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> My recent refactor of config.c accidentally removed the capability for a object to inherit from a non-template object.
> 
> The following was no longer valid and should have been:
> [mybase]
> something=else
> 
> [myobj](mybase)
> 
> This patch restores the capability to inherit from both template and non-template objects.
> 
> 
> Diffs
> -----
> 
>   branches/12/main/config.c 427199 
> 
> Diff: https://reviewboard.asterisk.org/r/4147/diff/
> 
> 
> Testing
> -------
> 
> Testsuite manager/config tests still pass.  main/config unit tests still pass.
> Eyeball test using AMI/GetConfig passed.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141104/9672b6a4/attachment.html>


More information about the asterisk-dev mailing list