[asterisk-dev] [Code Review] 4142: func_talkdetect: Fix stasis message leak in audiohook callback

Matt Jordan reviewboard at asterisk.org
Mon Nov 3 12:30:32 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4142/#review13660
-----------------------------------------------------------

Ship it!


Eek - that's what I get for eschewing usage of RAII_VAR.

- Matt Jordan


On Nov. 2, 2014, 10:02 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4142/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 10:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24482
>     https://issues.asterisk.org/jira/browse/ASTERISK-24482
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add missing cleanup for stasis_message.
> 
> 
> Diffs
> -----
> 
>   /branches/12/funcs/func_talkdetect.c 427023 
> 
> Diff: https://reviewboard.asterisk.org/r/4142/diff/
> 
> 
> Testing
> -------
> 
> tests/funcs/func_talkdetect no longer leaks - tested against 13.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141103/9ec54d34/attachment.html>


More information about the asterisk-dev mailing list