[asterisk-dev] [Code Review] 3577: bridge_native_rtp: Use combined result of both channels to determine bridge type.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3577/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-23541
    https://issues.asterisk.org/jira/browse/ASTERISK-23541


Repository: Asterisk


Description
-------

The bridge_native_rtp module currently uses the bridge result of the first channel that joins a bridge as the ultimate result. This means that if the first channel has direct media enabled but the second does not a direct media bridge will still occur.

This change makes it so that both sides are taken into account. If either side forbids the bridge or responds with a local bridge result then either a generic or local bridge occurs.


Diffs
-----

  /branches/12/bridges/bridge_native_rtp.c 414813 

Diff: https://reviewboard.asterisk.org/r/3577/diff/


Testing
-------

Configured two SIP endpoints: caller with direct media enabled and callee with direct media disabled. Placed a call from the caller to the callee.

Without this patch a reinvite occurs and the media is direct.
With this patch no reinvite occurs and media is locally exchanged.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140530/6cb0e62a/attachment.html>