[asterisk-dev] [Code Review] 3573: [main/config.c] AMI action UpdateConfig EmptyCat clears all categories but the requested one

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3573/#review11991
-----------------------------------------------------------

Ship it!


This is also applicable to 1.8 and seems to have been this way since the initial commit.

- Joshua Colp


On May 29, 2014, 7:56 a.m., zvision wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3573/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 7:56 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23803
>     https://issues.asterisk.org/jira/browse/ASTERISK-23803
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When invoking UpdateConfig AMI action with Action set to EmptyCat, the manager make all categories empty in the config but the one requested with a Cat variable. This is due to a bug in ast_category_empty (main/config.c) that makes incorrect comparison for a category name.
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/11/main/config.c 414808 
> 
> Diff: https://reviewboard.asterisk.org/r/3573/diff/
> 
> 
> Testing
> -------
> 
> Tested by me.
> 
> 
> Thanks,
> 
> zvision
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140529/66bd3568/attachment-0001.html>