[asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3541/#review11977
-----------------------------------------------------------

Ship it!


This looks good to me but I'd wait for one more person since anything to do with parsing could always use two sets, plus the overall change is large.


trunk/include/asterisk/http_websocket.h
<https://reviewboard.asterisk.org/r/3541/#comment21889>

    You have this as error here but it's actually result.


- Joshua Colp


On May 23, 2014, 7:30 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3541/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 7:30 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-23742
>     https://issues.asterisk.org/jira/browse/ASTERISK-23742
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add client websocket capabilities to Asterisk.
> 
> 
> Diffs
> -----
> 
>   trunk/tests/test_websocket_client.c PRE-CREATION 
>   trunk/res/res_http_websocket.exports.in 413541 
>   trunk/res/res_http_websocket.c 413541 
>   trunk/main/uri.c PRE-CREATION 
>   trunk/main/http.c 413541 
>   trunk/include/asterisk/uri.h PRE-CREATION 
>   trunk/include/asterisk/http_websocket.h 413541 
>   trunk/include/asterisk/http.h 413541 
> 
> Diff: https://reviewboard.asterisk.org/r/3541/diff/
> 
> 
> Testing
> -------
> 
> Created some unit tests.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140528/9544848e/attachment-0001.html>