[asterisk-dev] [Code Review] 3543: app_meetme: Don't interrupt MOH on waitmarked users.

rmudgett reviewboard at asterisk.org
Thu May 22 10:47:55 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3543/
-----------------------------------------------------------

(Updated May 22, 2014, 10:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 414401


Bugs: AST-1349
    https://issues.asterisk.org/jira/browse/AST-1349


Repository: Asterisk


Description
-------

Occasionally, when the last marked user leaves the conference, waitmarked users don't get MOH if MOH is supposed to be played while a waitmarked user is waiting for another marked user.

* Made not interrupt MOH when the user is a waitmarked user.  The waitmarked user doesn't need to hear any leave announcements from the conference as the user would have already heard different leave announcements if they were enabled.  Apparently DAHDI occasionally sends unending non-silent streams to these users or a normal user still in the conference has continuous high background noise.  These non-silent streams cause MOH to be suspended while the never ending "announcement" is played.

Issue caused by ASTERISK-13680.


Diffs
-----

  /branches/1.8/apps/app_meetme.c 413994 

Diff: https://reviewboard.asterisk.org/r/3543/diff/


Testing
-------

Added debugging statements to indicate when the MOH would have been suspended on the waitmarked user.
Got confirmation that the waitmerked user would not be suspended when the marked user leaves the conference.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140522/7882e939/attachment.html>


More information about the asterisk-dev mailing list