[asterisk-dev] [Code Review] 3547: Logger/CLI: Fix some aesthetic issues; clean up some chatty verbose messages

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3547/#review11957
-----------------------------------------------------------

Ship it!


Besides the point Walter had these look good to me, and some of the old log messages amuse me.

- Joshua Colp


On May 18, 2014, 8 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3547/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 8 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch addresses some aesthetic issues in Asterisk. These are all just minor tweaks to improve the look of the CLI when used in a variety of settings. Specifically:
>  * A number of chatty verbose messages were removed or demoted to DEBUG messages. Verbose messages with a verbosity level of 5 or higher were - if kept as verbose messages - demoted to level 4. Several messages that were emitted at verbose level 3 were demoted to 4, as announcement of dialplan applications being executed occur at level 3 (and so the effects of those applications should generally be less).
>  * Some verbose messages that only appear when their respective 'debug' options are enabled were bumped up to always be displayed.
>  * Prefix/timestamping of verbose messages were moved to the verboser handlers. This was done to prevent duplication of prefixes when the timestamp option (-T) is used with the CLI.
>  * Verbose magic is removed from messages before being emitted to non-verboser handlers. This prevents the magic in multi-line verbose messages (such as SIP debug traces or the output of DumpChan) from being written to files.
>  * _Slightly_ better support for the "light background" option (-W) was added. This includes using ast_term_quit in the output of XML documentation help, as well as changing the "Asterisk Ready" prompt to bright green on the default background (which stands a better chance of being displayed properly than bright white).
> 
> Overall, the output of starting Asterisk with the timestamp option is usable, the colours are a bit more consistent, and the messages displayed when starting Asterisk - with or without verbosity - is cleaner.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_odbc.c 414121 
>   /trunk/res/res_jabber.c 414121 
>   /trunk/res/res_fax.c 414121 
>   /trunk/res/res_config_pgsql.c 414121 
>   /trunk/res/res_config_odbc.c 414121 
>   /trunk/res/res_config_curl.c 414121 
>   /trunk/res/parking/parking_applications.c 414121 
>   /trunk/main/xmldoc.c 414121 
>   /trunk/main/pbx.c 414121 
>   /trunk/main/optional_api.c 414121 
>   /trunk/main/logger.c 414121 
>   /trunk/main/loader.c 414121 
>   /trunk/main/config_options.c 414121 
>   /trunk/main/bridge.c 414121 
>   /trunk/main/asterisk.c 414121 
>   /trunk/include/asterisk/logger.h 414121 
>   /trunk/channels/chan_unistim.c 414121 
>   /trunk/cel/cel_pgsql.c 414121 
>   /trunk/cel/cel_odbc.c 414121 
>   /trunk/cdr/cdr_sqlite3_custom.c 414121 
>   /trunk/cdr/cdr_pgsql.c 414121 
>   /trunk/cdr/cdr_odbc.c 414121 
>   /trunk/cdr/cdr_adaptive_odbc.c 414121 
>   /trunk/bridges/bridge_builtin_features.c 414121 
>   /trunk/apps/app_waitforsilence.c 414121 
>   /trunk/apps/app_voicemail.c 414121 
>   /trunk/apps/app_mixmonitor.c 414121 
> 
> Diff: https://reviewboard.asterisk.org/r/3547/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140522/2293d5cc/attachment.html>