[asterisk-dev] [Code Review] 3538: Partial fix to voicemail number maxmsg being overwritten.

[Matt Jordan]

> On May 14, 2014, 9:49 p.m., Matt Jordan wrote:
> > /trunk/apps/app_voicemail.c, lines 4458-4463
> > <https://reviewboard.asterisk.org/r/3538/diff/1/?file=58435#file58435line4458>
> >
> >     This change avoids the problem you've discovered by completely discarding the maxmsg limit set for the voicemail user. That doesn't feel like the correct solution here.
> >     
> >     (As an aside, I think your editor is inserting spaces instead of tabs - you may want to review the Coding Guidelines on the wiki)
> 
> Michael Young wrote:
>     I have been commenting on the issue tracker in regards to this.  I have not been able to re-produce the issue and have been asking for more details on how to reproduce the described issue.

Per Miguel's comment on the issue tracker and our inability to reproduce the problem, I'm going to close out this review.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3538/#review11891
-----------------------------------------------------------


On May 13, 2014, 2:30 p.m., Miguel Tavares wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3538/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 2:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23713
>     https://issues.asterisk.org/jira/browse/ASTERISK-23713
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Although it doesn't solve the issue 23713 it makes it a lot less likely to occur.
> 
> Another, maybe better, option might be to find the fist empty voicemail slot and use it to store the new message. This means changing the logic of how the messages are handled and as such as to be written and tested with more care.
> 
> A brief description of the problem. Setting the maxmsg to 3 (so vmu->maxmsg = 3). When the user has 3 messages he/she deletes the first two. In the file system we would have the files msg0003.wav and msg0003.txt. If a new message is being delivered then the last_message_index will return 2 and the message will be left in the slot 3, meaning that the previous msg0003 will be overwritten.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_voicemail.c 413892 
> 
> Diff: https://reviewboard.asterisk.org/r/3538/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miguel Tavares
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140522/93cd086a/attachment-0001.html>