[asterisk-dev] [Code Review] 3501: testsuite: add tests for ari userevents

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3501/#review11934
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/ari.py
<https://reviewboard.asterisk.org/r/3501/#comment21829>

    Remove this old, commented code since it has been replaced.



/asterisk/trunk/tests/rest_api/events/user/channel/test-config.yaml
<https://reviewboard.asterisk.org/r/3501/#comment21831>

    This section doesn't exist.



/asterisk/trunk/tests/rest_api/events/user/invalid/test-config.yaml
<https://reviewboard.asterisk.org/r/3501/#comment21830>

    This section doesn't exist.



/asterisk/trunk/tests/rest_api/events/user/multi/configs/extensions.conf
<https://reviewboard.asterisk.org/r/3501/#comment21833>

    This appears to be a duplicate and in the wrong place in the directory tree.



/asterisk/trunk/tests/rest_api/events/user/multi/test-config.yaml
<https://reviewboard.asterisk.org/r/3501/#comment21832>

    Is it possible to post with both a channel and a bridge simultaneously or does the "source" parameter prevent that?


- opticron


On May 12, 2014, 3:43 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3501/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 3:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22697
>     https://issues.asterisk.org/jira/browse/ASTERISK-22697
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Tests added:
> 
> 1) userevents/channel - check that the dialplan app Userevent() generated event produces correct ARI/AMI events
> 
> 2) userevents/multi - check that various forms of the ARI userevent generate correct ARI & AMI events
> 
> 3) userevents/invalid - check that correct result code is returned for invalid input cases
> 
> Changes to ari.py made to add expected: ### return code checking for HTTP requests.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/tests.yaml 5006 
>   /asterisk/trunk/tests/rest_api/events/user/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/multi/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/multi/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/multi/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/multi/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/invalid/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/invalid/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/channel/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/user/channel/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/events/tests.yaml PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/ari.py 5025 
> 
> Diff: https://reviewboard.asterisk.org/r/3501/diff/
> 
> 
> Testing
> -------
> 
> Tests pass with userevent code.  Also tested with r3496 valgrind support to insure no invalid references.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140520/bcccd0ce/attachment-0001.html>