[asterisk-dev] [Code Review] 3549: Replace __ast_answer with ast_raw_answer in app_control_answer

Joshua Colp reviewboard at asterisk.org
Mon May 19 12:25:23 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3549/#review11920
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On May 19, 2014, 5:20 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3549/
> -----------------------------------------------------------
> 
> (Updated May 19, 2014, 5:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23758
>     https://issues.asterisk.org/jira/browse/ASTERISK-23758
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While load testing an ARI application, I noticed asterisk was returning HTTP 500 internal server errors on channels/:id/answer.  After talking to #asterisk-dev, the issue appeared to be a lack of media flowing after __ast_answer() was called.  So now, we call ast_raw_answer instead and no longer wait for media.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_stasis_answer.c 414194 
> 
> Diff: https://reviewboard.asterisk.org/r/3549/diff/
> 
> 
> Testing
> -------
> 
> Local ARI application (payload-voice[1]) with SIPp (sipp -sn uac 127.0.0.1) to confirm HTTP 500 is no longer returned on answer.
> 
> [1] https://github.com/kickstandproject/payload-voice
> 
> 
> Thanks,
> 
> Paul Belanger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140519/e48a6b32/attachment.html>


More information about the asterisk-dev mailing list