[asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

opticron reviewboard at asterisk.org
Mon May 19 12:24:33 CDT 2014



> On May 12, 2014, 8:58 p.m., Matt Jordan wrote:
> > I feel like we're missing a SIPp scenario here. We have the initial receiver of the call, and we have the scenario that sends the REFER request - but where is the second SIP channel from the initiator of the transfer, and where is the destination of the transfer?

The only two SIPp scenarios involved here are the ones involved in the REFER. Both scenarios initiate a call into the dialplan: one into Stasis() and one into Echo(). After those are established, the leg that calls Echo() relays the requisite call information to the leg that calls Stasis() and the REFER is sent from there. Neither of these legs receive an invite.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3525/#review11877
-----------------------------------------------------------


On May 9, 2014, 2:13 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3525/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 2:13 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-23641
>     https://issues.asterisk.org/jira/browse/ASTERISK-23641
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This reworks a significant portion of the ARI attended transfer test to avoid dependence on pjsua since it has the tendency to cause sporadic (and sometimes consistent) test failures. The reworked test uses SIPp with 3PCC to manage the transfer scenario.
> 
> This change also gives WebSocketEventModule (and anything else using EventMatcher) the ability to spawn SIPp scenarios in response to websocket events.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml 5020 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/call_stasis.xml PRE-CREATION 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/call_echo.xml PRE-CREATION 
>   asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py 5020 
>   asterisk/trunk/lib/python/asterisk/ari.py 5020 
> 
> Diff: https://reviewboard.asterisk.org/r/3525/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the test was operating as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140519/fdd41e52/attachment.html>


More information about the asterisk-dev mailing list