[asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

[Olle E Johansson]

> On April 14, 2014, 2:24 p.m., Matt Jordan wrote:
> > /trunk/channels/chan_sip.c, lines 24306-24307
> > <https://reviewboard.asterisk.org/r/3437/diff/1/?file=57235#file57235line24306>
> >
> >     The 400/414 responses could occur for any request we send. How about moving them up to the 404 handling (line 24214)?
> >     
> >     That would mean some additional handling would be needed in handle_response_register and handle_response_subscribe, but it shouldn't be too much.

Hmmm. Maybe. < sipping a cup of tea while pondering this >


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3437/#review11598
-----------------------------------------------------------


On April 11, 2014, 9:29 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3437/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 9:29 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adding improved support for 400, 414 and 493 response codes.
> 
> I would like to add this as a bug fix to 1.8 and up.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 412166 
> 
> Diff: https://reviewboard.asterisk.org/r/3437/diff/
> 
> 
> Testing
> -------
> 
> A lot during interoperability tests.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140516/b175d3f8/attachment.html>