[asterisk-dev] [Code Review] 3439: chan_sip: Support a=rtcp attribute in SDP

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3439/
-----------------------------------------------------------

(Updated May 16, 2014, 2:36 p.m.)


Review request for Asterisk Developers.


Changes
-------

Adding a few comments. The patch works as is with many implementations, but lacks support of the IP address argument if that's used.


Repository: Asterisk


Description (updated)
-------

the A=rtcp attribute in SDP points out a different port than the mediaport+1 to receive RTCP on. This patch adds a new api to rtpengine and res_rtp_asterisk and updates chan_sip to use it.

This patch needs to be modified to handle the IP address argument too.


Diffs
-----

  /trunk/res/res_rtp_asterisk.c 412166 
  /trunk/main/rtp_engine.c 412166 
  /trunk/include/asterisk/rtp_engine.h 412166 
  /trunk/channels/chan_sip.c 412166 

Diff: https://reviewboard.asterisk.org/r/3439/diff/


Testing
-------

A massive amount of testing with a test tool for interoperability.


Thanks,

Olle E Johansson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140516/852351d4/attachment.html>