[asterisk-dev] [Code Review] 3536: res_musiconhold cleanup (part 1)

wdoekes reviewboard at asterisk.org
Wed May 14 10:27:52 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3536/
-----------------------------------------------------------

(Updated May 14, 2014, 10:27 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and opticron.


Changes
-------

Committed in revision 413894


Repository: Asterisk


Description
-------

A subset of https://reviewboard.asterisk.org/r/2742/

Parts of that patch have been committed already, others have been fixed in a different way, and others will be moved into a new review.

This patch does:

(5) free()'s were encountered that should be ast_free()'s.

(6) Added comment about LOGIC by tilghman:^H^H^H^H^H^H^H^H^H
    Reverted the code to the original, because the old comment seems wrong.

(8) Reorder a bit of code so a lock is paired with a single unlock.


Diffs
-----

  /branches/1.8/res/res_musiconhold.c 413786 

Diff: https://reviewboard.asterisk.org/r/3536/diff/


Testing
-------

It compiles.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140514/e90fc53b/attachment.html>


More information about the asterisk-dev mailing list