[asterisk-dev] [Code Review] 3539: pbx.c: segfault on recursive replace

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3539/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-23650
    https://issues.asterisk.org/jira/browse/ASTERISK-23650


Repository: Asterisk


Description
-------

Recursive usage of replace resulted in temporary string storage reuse and corruption.  This changes the variable storage from per-thread to allocated per call to replace().


Diffs
-----

  /branches/1.8/funcs/func_strings.c 413709 

Diff: https://reviewboard.asterisk.org/r/3539/diff/


Testing
-------

Tested with example dialplan under valgrind to eliminate the reference to realloc'd string storage.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140513/b45090b2/attachment.html>