[asterisk-dev] [Code Review] 3531: app_chanspy: Fix broken barge test and address an unfree'd frame I noticed.

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3531/
-----------------------------------------------------------

(Updated May 12, 2014, 3 p.m.)


Review request for Asterisk Developers, Joshua Colp, kmoore, and Matt Jordan.


Changes
-------

Address Josh's comment.


Repository: Asterisk


Description
-------

In https://reviewboard.asterisk.org/r/3505/ a behavior change in the barge code made frames not write to the spyee channel when barging while the spyee was not bridged.  This caused the test failure.  While I was at it I noticed an unfree'd frame, so I went ahead and fixed that.

Also, instead of locking both audiohooks and consuming them both before unlocking them both, this patch changes it so that these will happen one at a time.


Diffs (updated)
-----

  /branches/11/apps/app_chanspy.c 413706 

Diff: https://reviewboard.asterisk.org/r/3531/diff/


Testing
-------

Ran testsuite test apps/chanspy/chanspy_barge before and after.  With patch it passes, without patch it doesn't.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140512/bea2af98/attachment.html>