[asterisk-dev] [Code Review] 3530: Fix h264 SDP payload format

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3530/#review11871
-----------------------------------------------------------

Ship it!


Indeed, 3 octets in base16, not 3 base16 characters.

       profile-level-id:
                        A base16 [6] (hexadecimal) representation of
                        the following three bytes in the sequence
                        parameter set NAL unit specified in [1]: 1)
                        profile_idc, 2) a byte herein referred to as
                        profile-iop, composed of the values of
                        constraint_set0_flag, constraint_set1_flag,
                        constraint_set2_flag, and reserved_zero_5bits
                        in bit-significance order, starting from the
                        most significant bit, and 3) level_idc.

                        [...] the profile-level-id becomes 42E015 [...]

- wdoekes


On May 12, 2014, 8:18 a.m., Guillaume Maudoux wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3530/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 8:18 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23664
>     https://issues.asterisk.org/jira/browse/ASTERISK-23664
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Fix profile-level-id attribute to force six hex digits, where the printf format allowed less. (replace %X%X%X by %02X%02X%02X).
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_format_attr_h264.c 413694 
> 
> Diff: https://reviewboard.asterisk.org/r/3530/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guillaume Maudoux
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140512/fdaf6180/attachment.html>