[asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

[Scott Griepentrog]

> On May 6, 2014, 1:57 p.m., opticron wrote:
> > /asterisk/trunk/tests/rest_api/channels/playback/tones/test-config.yaml, lines 39-43
> > <https://reviewboard.asterisk.org/r/3428/diff/3/?file=58000#file58000line39>
> >
> >     Are these channel state changes important to the test? There doesn't seem to be much detail here.
> 
> Jonathan Rose wrote:
>     I don't think so, but they were present in the existing channel playback test (which was just for sounds).

They are not important to the test, but were an attempt to not have any events logged as not matching.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3428/#review11832
-----------------------------------------------------------


On May 7, 2014, 1:58 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3428/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 1:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23433
>     https://issues.asterisk.org/jira/browse/ASTERISK-23433
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> The YAML files have pretty apt descriptions.
> 
> Channel version:
> * Originate a channel
> * Playback a tone
> * Pause it
> * Unpause it
> * Restart it
> * Delete the tone playback
> * Delete the channel
> * Validate all the events
> 
> Bridge version:
> * Originate a channel
> * Create a bridge
> * Add the channel to the bridge
> * Start a tone playback on the bridge
> * Delete the tone playback
> * Delete the channel
> * Validate all the events
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/channels/playback/tones_w_tonezone/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/playback/tones_w_tonezone/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/playback/tones/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/playback/tones/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/playback/tests.yaml 4991 
>   /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/playback/tones/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/playback/tones/bridges_play.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/playback/tests.yaml 4991 
> 
> Diff: https://reviewboard.asterisk.org/r/3428/diff/
> 
> 
> Testing
> -------
> 
> Ran tests, varied results, the usual.  They aren't especially changed from the tests they are based on (in each case there is an existing baseline test in the same folder which handles sounds).
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140508/9e76757c/attachment.html>