[asterisk-dev] [Code Review] 3520: libpri: Add control of inband audio progress indication ie to the SETUP_ACKNOWLEDGE message.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3520/#review11838
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On May 1, 2014, 8:48 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3520/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 8:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1338
>     https://issues.asterisk.org/jira/browse/AST-1338
> 
> 
> Repository: LibPRI
> 
> 
> Description
> -------
> 
> This review and https://reviewboard.asterisk.org/r/3521/ work together to allow Asterisk to control the inband audio available progress indication ie on the SETUP_ACKNOWLEDGE message when dialtone is present.
> 
> Added support to the libpri API to control the inband audio available progress indication ie on the SETUP_ACKNOWLEDGE message.
> 
> * Added the progress indication ie progressmak value to the struct pri_event_setup_ack so the PRI_EVENT_SETUP_ACK event can indicate when a SETUP_ACKNOWLEDGE comes in with inband audio (ie dialtone).
> 
> * Added pri_setup_ack() so when the SETUP_ACKNOWLEDGE message is sent it can indicate if inband audio is present (ie dialtone).
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/q931.c 2319 
>   /branches/1.4/pri_q931.h 2319 
>   /branches/1.4/pri.c 2319 
>   /branches/1.4/libpri.h 2319 
> 
> Diff: https://reviewboard.asterisk.org/r/3520/diff/
> 
> 
> Testing
> -------
> 
> Sent calls over an ISDN trunk with overlap dialing enabled that did and did not present dialtone for more digits.
> Observed that the inband audio available progress indication ie was sent when needed on the SETUP_ACKNOWLEDGE message.
> Added a debug message that indicated when Asterisk did and did not receive the inband audio indication for the SETUP_ACKNOWLEDGE message.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140507/2fe04165/attachment-0001.html>