[asterisk-dev] [Code Review] 3512: media formats: Convert the translation core over

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3512/#review11808
-----------------------------------------------------------



team/group/media_formats-reviewed/main/translate.c
<https://reviewboard.asterisk.org/r/3512/#comment21649>

    This loop is effectively a no-op since curlen is never set to anything within the loop.



team/group/media_formats-reviewed/main/translate.c
<https://reviewboard.asterisk.org/r/3512/#comment21650>

    This should be
    
    dst_fmt_out = ast_format_copy(bestdst);



team/group/media_formats-reviewed/main/translate.c
<https://reviewboard.asterisk.org/r/3512/#comment21651>

    This is doing the opposite of what the old code did.



team/group/media_formats-reviewed/main/translate.c
<https://reviewboard.asterisk.org/r/3512/#comment21652>

    These are the exact same calls twice in a row. I assume one was supposed to use AST_MEDIA_TYPE_VIDEO?


- Mark Michelson


On April 30, 2014, 9:22 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3512/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 9:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: SWP-6725
>     https://issues.asterisk.org/jira/browse/SWP-6725
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Updated the translation core (translate.c) to use the new media format API.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed/main/translate.c 413143 
>   team/group/media_formats-reviewed/main/format.c 413143 
>   team/group/media_formats-reviewed/main/codec.c 413143 
>   team/group/media_formats-reviewed/include/asterisk/format.h 413143 
>   team/group/media_formats-reviewed/include/asterisk/codec.h 413143 
> 
> Diff: https://reviewboard.asterisk.org/r/3512/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140501/c9353453/attachment-0001.html>