[asterisk-dev] [Code Review] 3515: media_formats: Move chan_pjsip over.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3515/#review11803
-----------------------------------------------------------



/team/group/media_formats-reviewed/channels/chan_pjsip.c
<https://reviewboard.asterisk.org/r/3515/#comment21636>

    Sorry I hadn't noticed this before, but I think these two lines right next to each other highlight a naming consistency issue in the API (bytype vs. by_type). I suggest that somewhere outside this review, you make a change so that one or the other is followed and you don't have this weird mix.



/team/group/media_formats-reviewed/res/res_pjsip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/3515/#comment21639>

    Just remove this.



/team/group/media_formats-reviewed/res/res_pjsip_sdp_rtp.c
<https://reviewboard.asterisk.org/r/3515/#comment21640>

    Just remove the code instead of commenting it out.


- Mark Michelson


On April 30, 2014, 10:49 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3515/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 10:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves chan_pjsip and the other PJSIP modules over to the new media formats work.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/res/res_pjsip_session.c 413144 
>   /team/group/media_formats-reviewed/res/res_pjsip_sdp_rtp.c 413144 
>   /team/group/media_formats-reviewed/res/res_pjsip/pjsip_configuration.c 413144 
>   /team/group/media_formats-reviewed/include/asterisk/res_pjsip_session.h 413144 
>   /team/group/media_formats-reviewed/include/asterisk/res_pjsip.h 413144 
>   /team/group/media_formats-reviewed/include/asterisk/format_cache.h 413144 
>   /team/group/media_formats-reviewed/channels/pjsip/dialplan_functions.c 413144 
>   /team/group/media_formats-reviewed/channels/chan_pjsip.c 413144 
> 
> Diff: https://reviewboard.asterisk.org/r/3515/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140501/31edb5b7/attachment-0001.html>