[asterisk-dev] [Code Review] 3408: app_voicemail: fix regression caused by dialplan function safety fixes - Asterisk 11 only

[Corey Farrell]

> On March 30, 2014, 2:33 p.m., Matt Jordan wrote:
> > Ship It!
> 
> Matt Jordan wrote:
>     If you'd like to rename it, that's fine. It doesn't appear as if anything else would be using the current name (since it wouldn't link...)
>     
>

app_voicemail (now that I've modified it) is the only module to use the defaultlanguage symbol, all other uses are from the asterisk core.  I've made the changes to my working copy, once that finishes compiling and loads successfully I'll update the review.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3408/#review11442
-----------------------------------------------------------


On March 29, 2014, 3:21 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3408/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 3:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23559
>     https://issues.asterisk.org/jira/browse/ASTERISK-23559
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> ASTERISK-23391 caused a regression in Asterisk 11. defaultlanguage is used as a fall-back when no channel is available. This variable is listed in options.h, allowing compile to succeed. This caused a run-time symbol failure because defaultlanguage is not listed in main/asterisk.exports.in.
> 
> This fix adds the variable to exports for Asterisk 11 only.  I'm not against renaming the variable to ast_defaultlanguage in 11 if that is preferred.  The function wasn't in Asterisk 1.8 so no change was made there, Asterisk 12 renames the variable to ast_defaultlanguage so it was not a problem in 12+.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/asterisk.exports.in 411572 
> 
> Diff: https://reviewboard.asterisk.org/r/3408/diff/
> 
> 
> Testing
> -------
> 
> Verified this corrects the symbol failure.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140330/c258a1af/attachment-0001.html>