[asterisk-dev] [Code Review] 3406: AGI/Manager: Prevent multiple Newexten events from occuring from AGI application changes

Matt Jordan reviewboard at asterisk.org
Fri Mar 28 21:41:35 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3406/#review11439
-----------------------------------------------------------

Ship it!


I didn't see any CDR, dial, or unit test failures either.

Not sure why I added that code but... oh well!

- Matt Jordan


On March 28, 2014, 4:36 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3406/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 4:36 p.m.)
> 
> 
> Review request for Asterisk Developers, Benjamin Keith Ford and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23390
>     https://issues.asterisk.org/jira/browse/ASTERISK-23390
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A major CDR patch to accomodate the bridging framework introduced this change. It added an extra condition to bail on issuing the event when context, extension, and priority are equal to require the application to match as well. This was probably simply a mistaken addition to the event since the CDR handlers for the same stasis messages likely should respond to application changes even when the extensions aren't changing.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/manager_channels.c 411309 
> 
> Diff: https://reviewboard.asterisk.org/r/3406/diff/
> 
> 
> Testing
> -------
> 
> I've ran a wide range of testsuite tests to confirm that nothing is expecting multiple Newexten manager events to be issued and this change doesn't introduce any test failures. Newexten events should be the only thing affected by this change and not any stasis messages that are actually used for internal purposes.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140329/e227794e/attachment-0001.html>


More information about the asterisk-dev mailing list