[asterisk-dev] [Code Review] 3402: http: response body frequently missing when running in virtual machine

Scott Griepentrog reviewboard at asterisk.org
Fri Mar 28 11:16:09 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3402/
-----------------------------------------------------------

(Updated March 28, 2014, 11:16 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 411462


Bugs: ASTERISK-23548
    https://issues.asterisk.org/jira/browse/ASTERISK-23548


Repository: Asterisk


Description
-------

When running asterisk in a virtual machine, responses to ARI requests would frequently be missing.  A race condition related to closing the socket immediately after writing data onto it is resolved in this patch by insuring the output stream is flushed, and then informing TCP of the shutdown prior to the close.


Diffs
-----

  /branches/1.8/main/tcptls.c 411312 
  /branches/1.8/main/manager.c 411312 
  /branches/1.8/main/http.c 411312 

Diff: https://reviewboard.asterisk.org/r/3402/diff/


Testing
-------

Tested on Ubuntu server 12.04 with Sam's json api test from issue.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140328/a16980aa/attachment.html>


More information about the asterisk-dev mailing list