[asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

[Kevin Harwell]

> On March 27, 2014, 4:45 p.m., Kevin Harwell wrote:
> > ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample, lines 10-12
> > <https://reviewboard.asterisk.org/r/3313/diff/3/?file=56735#file56735line10>
> >
> >     Maybe make this a little more specific like 'ami-id'
> 
> opticron wrote:
>     Using "id" for the AMI ID is the convention used for all other pluggable modules. This probably shouldn't buck the trend.

Since that is the case, agreed and this issue can be dropped.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3313/#review11407
-----------------------------------------------------------


On March 27, 2014, 1:06 p.m., Scott Emidy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3313/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 1:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23217
>     https://issues.asterisk.org/jira/browse/ASTERISK-23217
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test uses the Pluggable Module Framework in order to convert a YAML configuration into an executable Call File by putting it into the correct directory, which is the 'astspooldir' directory.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/pbx/tests.yaml 4726 
>   ./asterisk/trunk/tests/pbx/create_call_files/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/create_call_files/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample PRE-CREATION 
>   ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4726 
> 
> Diff: https://reviewboard.asterisk.org/r/3313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Emidy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140328/3fd375ec/attachment.html>