[asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

[zvision]

> On March 28, 2014, 4:15 a.m., Matt Jordan wrote:
> > I'm going to go ahead and push this into 1.8, 11, and 12.
> 
> Matt Jordan wrote:
>     Scratch that, I'll block this on 12.

I've submitted a proper patch for trunk (and 12) version here: https://reviewboard.asterisk.org/r/3335/. The only difference
is no config option to maintain backwards compatibility. Maybe for branch 12, there should be the same option as for 1.8 and 11
to be backwards compatible...


- zvision


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3375/#review11420
-----------------------------------------------------------


On March 28, 2014, 4:24 a.m., zvision wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3375/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 4:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23459
>     https://issues.asterisk.org/jira/browse/ASTERISK-23459
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This review request is a patch for the issue reviewed in https://reviewboard.asterisk.org/r/3335 but for non-trunk versions.
> 
> Changes:
> - correct check for keyfield existence,
> - new res_odbc.conf variable allow_empty_string_in_nontext,
> - proper empty string => NULL conversion with allow_empty_string_in_nontext option disabled
>   for non-text columns.
> 
> This patch is based on branch 11 svn, but code for 1.8 and 10 is the same, so it should apply with no problems.
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/11/res/res_odbc.exports.in 411017 
>   http://svn.asterisk.org/svn/asterisk/branches/11/res/res_odbc.c 411017 
>   http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c 411017 
>   http://svn.asterisk.org/svn/asterisk/branches/11/include/asterisk/res_odbc.h 411017 
>   http://svn.asterisk.org/svn/asterisk/branches/11/configs/res_odbc.conf.sample 411017 
> 
> Diff: https://reviewboard.asterisk.org/r/3375/diff/
> 
> 
> Testing
> -------
> 
> Tested with Asterisk 11 + ODBC + SIP realtime + PostgreSQL with both allow_empty_string_in_nontext settings
> to ensure no regression is introduced.
> 
> 
> Thanks,
> 
> zvision
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140328/508f61df/attachment.html>