[asterisk-dev] [Code Review] 3387: media_formats: Move chan_dahdi over.

Mark Michelson reviewboard at asterisk.org
Thu Mar 27 14:03:48 CDT 2014



> On March 27, 2014, 7:02 p.m., Mark Michelson wrote:
> > /team/group/media_formats-reviewed/channels/chan_dahdi.c, lines 16557-16558
> > <https://reviewboard.asterisk.org/r/3387/diff/1/?file=56446#file56446line16557>
> >
> >     You could use:
> >     
> >     dahdi_tech.capabilities = ao2_cleanup(dahdi_tech.capabilities);
> >     
> >     here instead if you wished.

Actually ignore this. Apparently ao2_cleanup doesn't return NULL like I thought it did.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3387/#review11398
-----------------------------------------------------------


On March 25, 2014, 11:11 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3387/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 11:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves the chan_dahdi module over to the new media formats API.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/channels/dahdi/bridge_native_dahdi.c 409286 
>   /team/group/media_formats-reviewed/channels/chan_dahdi.c 409286 
> 
> Diff: https://reviewboard.asterisk.org/r/3387/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140327/72be937b/attachment.html>


More information about the asterisk-dev mailing list