[asterisk-dev] [Code Review] 3400: Nominal DISA Authentication Test

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3400/#review11395
-----------------------------------------------------------

Ship it!


Just the one minor nitpick below.


./asterisk/trunk/tests/apps/disa/nominal/authenticate/test-config.yaml
<https://reviewboard.asterisk.org/r/3400/#comment21042>

    BridgeWait() doesn't appear to be used in the provided dialplan.


- opticron


On March 26, 2014, 10:38 a.m., Benjamin Keith Ford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3400/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 10:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23521
>     https://issues.asterisk.org/jira/browse/ASTERISK-23521
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test has a channel enter the DISA application, where it will be required to enter a passcode. Once successfully entered, the desired extension must be entered in. When a valid extension is submitted, the channel should be redirected to that extension and execute the dialplan there.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/apps/tests.yaml 4894 
>   ./asterisk/trunk/tests/apps/disa/tests.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/apps/disa/nominal/tests.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/apps/disa/nominal/authenticate/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/apps/disa/nominal/authenticate/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Keith Ford
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140327/3e95f525/attachment.html>