[asterisk-dev] [Code Review] 3376: Crash in ast_format_cmp during non-clean shutdown

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3376/#review11386
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On March 19, 2014, 5:40 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3376/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 5:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Joshua Colp, Mark Michelson, n8ideas, rmudgett, and Scott Griepentrog.
> 
> 
> Bugs: ASTERISK-23103
>     https://issues.asterisk.org/jira/browse/ASTERISK-23103
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Backport ast_register_cleanup, use it for format_attr_shutdown to ensure that format interfaces container is not cleaned during non-graceful shutdown.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/format.c 410826 
>   /branches/11/main/asterisk.c 410826 
>   /branches/11/include/asterisk.h 410826 
> 
> Diff: https://reviewboard.asterisk.org/r/3376/diff/
> 
> 
> Testing
> -------
> 
> I verified after applying this patch I am unable to cause a segfault by running 'killall asterisk' while a call is active.  This test causes a SEGV every time without the patch.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140326/f394ac1c/attachment.html>